CSTACKEX-270: Automation for the template cache workflows - #99
rajiv-jain-netapp wants to merge 5 commits into
Conversation
Club template-cache product changes with Marvin automation for a combined validation pass.
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.69% |
| Branch coverage | 18.83% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.69% |
| Branch coverage | 18.83% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
sandeeplocharla
left a comment
sandeeplocharla
left a comment
There was a problem hiding this comment.
The tests could be made part of existing storage pool testcases. Please check its feasibility. We might not have to create pool, disk offering, etc., separately for this.
addressed |
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.75% |
| Branch coverage | 18.87% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
| % name_suffix | ||
| ) | ||
| except Exception as ex: | ||
| logger.info( |
There was a problem hiding this comment.
self.fail() raises an AssertionError which come under catch block and here only logger so test will return as pass
| self.__class__.vm = vm | ||
|
|
||
| result = self._poll_vm_state(vm.id, "Running", timeout=300) | ||
| result = self._poll_vm_state(vm.id, "Running", timeout=900) |
There was a problem hiding this comment.
This could significantly increase the time to fail.
| vm2 = self.apiClient.deployVirtualMachine(cmd) | ||
| self.assertIsNotNone(vm2, "deployVirtualMachine returned None") | ||
| self.__class__.vm2 = vm2 | ||
| self._poll_vm_state(vm2.id, "Running", timeout=900) |
There was a problem hiding this comment.
Check if the timeout could be reduced
| "enabled": true, | ||
| "storagePoolTags": "ontap-nfs3" | ||
| "storagePoolTags": "ontap-nfs3", | ||
| "templateCacheTags": "ontap-nfs3-tmpl-cache" |
There was a problem hiding this comment.
Instead in template cache negative test case file 'storagePoolTags' + "-tmpl-cache", could be used.
Even for iscsi case also
| ) | ||
|
|
||
|
|
||
| class OntapTemplateCacheBase(TemplateCacheAssertionsMixin, OntapTestBase): |
There was a problem hiding this comment.
Currently, for ontap plugin template cache is the only way we create VMs right? As users can't opt out, I feel it's better to update the ontap base file itself, instead of having a separate template_cache_base.py?
4 participants
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?